Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 86.33% 86.48% +0.14%
==========================================
Files 32 32
Lines 1910 1931 +21
==========================================
+ Hits 1649 1670 +21
Misses 261 261
🚀 New features to boost your workflow:
|
Since curlInterface can write the body to a file itself, let it: the file then never passes through memory. Older versions ignore the option and still return the contents, which are written here as before. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
A download interrupted halfway currently starts again from zero, which for a data set of any size is the difference between a retry and an afternoon. With 'resume' set and a target given, the curl and wget methods continue the partial file. The clean-up in 'Download' skips the target for the same reason: otherwise it would throw away the very thing the next attempt is meant to continue. Methods that cannot resume decline the request rather than proceeding to avoid destroying the partial file the resuming methods need. 'resume' is deliberately left unbound when the caller does not ask for it, rather than defaulted to false. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
The clean-up added in #103 removes 'opt.target' after any failed method, which also removes a file that was there before the call. A failed download then destroys a file it never created. Remember whether the file existed when 'Download' was entered, and remove it only if it did not. This also lets the wget method drop its own removal: with the caller's file protected in one place, the per-method clean-up is redundant, and 'RemoveFile' is now called from exactly one place instead of two that disagreed about whether to signal an error when it fails. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Member
|
Download PRs are merged now. BTW, typo: superceded -> superseded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfinished - waiting for the download PRs to be finished.