Skip to content

removing files superceded by utils0-.tst - #108

Merged
cdwensley merged 11 commits into
masterfrom
extract
Sep 9, 2026
Merged

removing files superceded by utils0-.tst#108
cdwensley merged 11 commits into
masterfrom
extract

Conversation

@cdwensley

Copy link
Copy Markdown
Collaborator

Unfinished - waiting for the download PRs to be finished.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.48%. Comparing base (3db5598) to head (2fee2e5).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   86.33%   86.48%   +0.14%     
==========================================
  Files          32       32              
  Lines        1910     1931      +21     
==========================================
+ Hits         1649     1670      +21     
  Misses        261      261              
Files with missing lines Coverage Δ
lib/download.gi 94.69% <100.00%> (+1.03%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fingolfin and others added 3 commits September 9, 2026 00:20
Since curlInterface can write the body to a file itself, let it: the file
then never passes through memory. Older versions ignore the option and
still return the contents, which are written here as before.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
A download interrupted halfway currently starts again from zero,
which for a data set of any size is the difference between a retry
and an afternoon.

With 'resume' set and a target given, the curl and wget methods
continue the partial file. The clean-up in 'Download' skips the
target for the same reason: otherwise it would throw away the very
thing the next attempt is meant to continue.

Methods that cannot resume decline the request rather than
proceeding to avoid destroying the partial file the resuming
methods need.

'resume' is deliberately left unbound when the caller does not ask
for it, rather than defaulted to false.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
The clean-up added in #103 removes 'opt.target' after any failed method,
which also removes a file that was there before the call.  A failed
download then destroys a file it never created.

Remember whether the file existed when 'Download' was entered, and remove
it only if it did not.

This also lets the wget method drop its own removal: with the caller's
file protected in one place, the per-method clean-up is redundant, and
'RemoveFile' is now called from exactly one place instead of two that
disagreed about whether to signal an error when it fails.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@fingolfin

Copy link
Copy Markdown
Member

Download PRs are merged now.

BTW, typo: superceded -> superseded

@cdwensley
cdwensley merged commit 34fb112 into master Sep 9, 2026
5 checks passed
@cdwensley
cdwensley deleted the extract branch September 9, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants